Formal
Yang validation
Each published yang should be validated using the tool pyang. The community ususally takes care, that the yang modules also valid to be used by ONOS yang tools, OpenDaylight yang tools, Netopeer and other NetConf client and server implementations.
The minium requirement would be that pyang does not report errors and warnings when using the "--strict" option. However, it would be preferred that pyang also does not report errors and warnings, when using the "--lint" option.
Code Block |
---|
pyang --strict *.yang ( minimum: no errors, no warnings) pyang --lint *.yang (preferred: no errors, no warnings) |
Providing yang modules
Public access to yang modules would be very benifical, avoiding error prune and time consuming extraction from word documents.
- https://github.com/YangModels/yang
- http://www.netconfcentral.org
- and of cause the related 3GPP TS page
... are good candidates to publish agreed and reviewed 3GPP yang modules.
License statement
Please add the 3GPP License statement to the yang modul description statement.
TS 28.541 v16.1.0 example | Proposal | ||||
---|---|---|---|---|---|
|
|
YANG mechanics
Revision in import statements
The "revision date" in yang import statements should be avoided to gain more flexibility, when the imported yang module is update. It avoids updates of the importing yang model.
TS 28.541 v16.1.0 example | Proposal | ||||
---|---|---|---|---|---|
|
|
Yang submodules vs. Yang augment statement.
The usage of submodules and include statements create a monolithic interface description block - from developer point of view.
To address the expected high dynamic in 5G features and its OAM modules, Each submodule should be changed to a full module augmenting its parent module.
YANG content
Vendor specific container
The yang module "Vendor specific data container" is not needed, because each vendor (and operator) can augment each yang module to address vendor specific features. This yang feature makes such vendor specific data container model obsolete. Please note that other schemas may still require such model.
TODOs
- TS 28.541 specifies the acutal plugged equipment → search for required/expected/planned equipment.
- Check where the topology is defined beween CU, DU and RU.