Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

RanListManager

  • An optimization suggestion (APPROVED) - instead managing a list of []*NbIdentity, manage a map of [string]*NbIdentity, where key is inventoryName and value is the nbIdentity.


Code Block
titleRanListManager
type RanListManager struct {
	rnibDataService services.RNibDataService
	mux sync.Mutex
	nbIdentityListnbIdentityMap map[string]*NbIdentity
}

type IRanListManager interface {
	InitNbIdentityListInitNbIdentityMap() error
	AddNbIdentity(nodeType entities.Node_Type, nbIdentity *entities.NbIdentity) error
	UpdateNbIdentity(nodeType entities.Node_Type, nbIdentity *entities.NbIdentity) error
	RemoveNbIdentity(nodeType entities.Node_Type, nbIdentity *entities.NbIdentityranName string) error
	GetNbIdentityList() []*entities.NbIdentity
}

...

Info
  • Triggered on application init, fetches nb identity list from DB and set it on populate nbIdentityMap data member.
  • rnib error → os.Exit(1)


Image RemovedImage Added

AddNbIdentity


Info

SaveNodeb Calls will be followed by a ranListManager.AddNbIdentity(nodeType, nbIdentity) call.

AFFECTED FLOWS

  • Add Enb REST API
  • E2 Setup Request coming from NW

Image RemovedImage Added


Add Enb REST API

Image RemovedImage Added

E2 Setup Request coming from NW

Image RemovedImage Added

UpdateNbIdentity

...

Info
  • RemoveEnb call will be followed by ranListManager.RemoveNbIdentity(nodeType, nbIdentity) call
  • Currently, there's no RemoveGnb method (there's only RemoveServedNrCells)

AFFECTED FLOWS

  • Delete Enb REST API

Image RemovedImage Added

Delete ENB REST API

...

  • Returns the in-memory nbIdentity list (iterate map values and append to a []*NbIdentity slice)
  • Affected flows: Get Nodeb Ids REST API & Red Button

...

  • SaveNodeb(nbIdentity *entities.NbIdentity, nodebInfo *entities.NodebInfo) error
    • Change signature to: SaveNodeb(nbIdentity *entities.NbIdentity, nodebInfo *entities.NodebInfo) error
    • Modify implementation:
      • Remove UNKNOWN nodeType handling (reason: setup is now deterministic)
      • Remove save nbIdentity code - it would be called sequentially externally

  • RemoveEnb(nodebInfo *entities.NodebInfo) error
    • Modify implementation:
      • Delete remove nbIdentity code - it would be called sequentially externally

...

  • GetListNodebIds() ([]*entities.NbIdentity, error)
    • Remove UNKNOWN nodeType handling (reason: setup is now deterministic)


Optimization suggestions

...

...