RanListManager

• An optimization suggestion (APPROVED) - instead managing a list of []*NbIdentity, manage a map of [string]*NbIdentity, where key is inventoryName and value is the nbIdentity.

type RanListManager struct {
	rnibDataService services.RNibDataService
	mux sync.Mutex
	nbIdentityListnbIdentityMap map[string]*NbIdentity
}

type IRanListManager interface {
	InitNbIdentityListInitNbIdentityMap() error
	AddNbIdentity(nodeType entities.Node_Type, nbIdentity *entities.NbIdentity) error
	UpdateNbIdentityUpdateNbIdentityConnectionStatus(nodeType entities.Node_Type, nbIdentity * ranName string, connectionStatus entities.NbIdentityConnectionStatus) error
	RemoveNbIdentity(nodeType entities.Node_Type, nbIdentity *entities.NbIdentityranName string) error
	GetNbIdentityList() []*entities.NbIdentity
}

...

Image RemovedImage Added

AddNbIdentity

Image RemovedImage Added

Add Enb REST API

Image RemovedImage Added

E2 Setup Request coming from NW

Image RemovedImage Added

...

UpdateNbIdentityConnectionStatus

Image RemovedImage Added

RanStateChangeManager

Image RemovedImage Added

RemoveNbIdentity

...

Image RemovedImage Added

Delete ENB REST API

...

• Returns the in-memory nbIdentity list (iterate map values and append to a []*NbIdentity slice)
• Affected flows: Get Nodeb Ids REST API & Red Button

...

• SaveNodeb(nbIdentity *entities.NbIdentity, nodebInfo *entities.NodebInfo) error
  • Change signature to: SaveNodeb(nbIdentity *entities.NbIdentity, nodebInfo *entities.NodebInfo) error
  • Modify implementation:
    • Remove UNKNOWN nodeType handling (reason: setup is now deterministic)
    • Remove save nbIdentity code - it would be called sequentially externally
      
      
• RemoveEnb(nodebInfo *entities.NodebInfo) error
  • Modify implementation:
    • Delete remove nbIdentity code - it would be called sequentially externally

...

AddNbIdentity(nodeType entities.Node_Type, nbIdentity *entities.NbIdentity) error
UpdateNbIdentityUpdateNbIdentities(nodeType entities.Node_Type, oldNbIdentityoldNbIdentities []*entities.NbIdentity, newNbIdentitynewNbIdentities []*entities.NbIdentity) error
RemoveNbIdentity(nodeType entities.Node_Type, nbIdentity *entities.NbIdentity) error

...

Optimization suggestions

• Instead managing a list of []*NbIdentity, manage a map of [string]*NbIdentity, where key consist of plmnId:nbId and value is the nbIdentity.Instead of managing a SET in REDIS DB, manage a HASH (read more: https://redis.io/topics/data-types | https://redis.io/topics/memory-optimization)