...
- Every time: Check rule RC-4 (link) that all L or XL commits of the last two weeks have also new unit tests. This is our policy. link-to-reviews (gerrit filter instructions // gerrit t-shirt-sizing).
- https://gerrit.o-ran-sc.org/r/c/ric-plt/rtmgr/+/5990 (send e-mail to Nune+ AbdulwahidAbdulwahid checked this. It's only M size as the commit incorrectly replace many lines with spaces to tabs. Also review 6105 actually fixes some test cases in this area: This should be sufficient as the underlying functionality wasn't changed)
- https://gerrit.o-ran-sc.org/r/c/ric-plt/submgr/+/6132 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/vespamgr/+/5987 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/xapp-frame/+/6014 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/ric-dep/+/5826 (ok, even if no test cases as this is yaml files (Helm chart) repackaged.)
- https://gerrit.o-ran-sc.org/r/c/ric-plt/sdlpy/+/6060 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/sdlgo/+/6061 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/sdlgo/+/6062 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/submgr/+/6082 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/submgr/+/6109 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/rtmgr/+/6112 ok
- https://gerrit.o-ran-sc.org/r/c/ric-plt/libe2ap/+/6131(still in review, Thoralf commented that unit test cases to be added)
- https://gerrit.o-ran-sc.org/r/c/ric-plt/submgr/+/6081 (replaced by other review, anyway contains test cases, but will likely be abandoned anyway)
- every second time: Review code coverage stats . (Sunil checks if this next step (overview page) is on HCL or on Thoralf's side as next action) - will discuss with Thoralf next time or by email.
and blocker code smells- We take a look at the two links in the beginning of this page: Code coverage reports
- As of 2021-05-25 the following components are missing in the report: ric-plt/alarm-cpp, ric-plt/libe2ap, ric-plt/nodeb-rnib, ric-plt/o1, ric-plt/ric-dep, ric-plt/ric-test, ric-plt/sdlpy. Also ric-plt/jaegeradapter is missing, but we probably abandon that component. So no need to spend time on it.
- ric-plt/e2 is already being handled via RIC-731 (expected to complete in Dawn)
- https://sonarcloud.io/organizations/o-ran-sc/projects?search=ric&sort=coverage
- Next step: Thoralf to create some way to maintain history data
- Thoralf updated the CII evaluation criteria. We are now marked as "passed": Core Infrastructure Initiative (CII) Badging and https://bestpractices.coreinfrastructure.org/en/projects/4605
- Note I added RC-5 in Release criteria checklist template "RC-5: Check that "blocker" code smells in Sonartype have been addressed"
- Sunil. RIC-723 further input needed from Thoralf
- demos again?
- From last meeting:
- Thoralf to discuss demos for Nokia features.
- Possible influxDB demo to show how to use from xApps
- Possible demos in devops areas (e.g. RIC-754)
- demo for RIC-747/RIC-748 slidesets
- From last meeting:
- RICAPP agenda: RICAPP Meetings.
...